Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alloy): convert non-sensitive secret values to strings #81

Merged
merged 1 commit into from
Sep 14, 2024
Merged

fix(alloy): convert non-sensitive secret values to strings #81

merged 1 commit into from
Sep 14, 2024

Conversation

sid-maddy
Copy link
Contributor

We're using Secret data in places where Alloy expects strings, not secrets.

@sid-maddy
fix(alloy): convert non-sensitive secret values to strings
e1f6ca0 
We're using `Secret` data in places where Alloy expects strings, not secrets.
@sid-maddy sid-maddy self-assigned this Sep 14, 2024
jonathan-d-zhang
jonathan-d-zhang approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@jonathan-d-zhang jonathan-d-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😔

@sid-maddy sid-maddy merged commit e1f6ca0 into main Sep 14, 2024
3 checks passed
@sid-maddy sid-maddy deleted the sid/bugfix/alloy branch September 14, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-d-zhang jonathan-d-zhang jonathan-d-zhang approved these changes

@Robin5605 Robin5605 Awaiting requested review from Robin5605

Assignees

@sid-maddy sid-maddy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sid-maddy @jonathan-d-zhang